feat: introduces startTime and endTime

googleapis · Oct 7, 2019 · 4406446 · 4406446
1 parent 7576ef2
commit 4406446
Show file tree

Hide file tree

Showing 7 changed files with 36,025 additions and 6 deletions.
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,5 +1,5 @@
 Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
-- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/{{metadata['repo']['name']}}/issues) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
+- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/nodejs-logging/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
 - [ ] Ensure the tests and linter pass
 - [ ] Code coverage does not decrease (if any source code was changed)
 - [ ] Appropriate docs were updated (if necessary)

diff --git a/protos/google/logging/v2/logging_config.proto b/protos/google/logging/v2/logging_config.proto
@@ -374,6 +374,12 @@ message LogSink {
   //
   // This field may not be present for older sinks.
   google.protobuf.Timestamp update_time = 14;
+
+  // Do not use. This field is ignored.
+  google.protobuf.Timestamp start_time = 10 [deprecated = true];
+
+  // Do not use. This field is ignored.
+  google.protobuf.Timestamp end_time = 11 [deprecated = true];
 }
 
 // Options that change functionality of a sink exporting data to BigQuery.