-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix resource autodetection for GKE, GAE, and GCE #1070
Conversation
Warning: This pull request is touching the following templated files:
|
Heya! Would it be possible to mention in the docs somewhere or in the readme the gotcha about It's a super useful PR but I was left scratching my head for a few hours and it took looking through the source to figure out why that field alone wasn't populated :/ Thanks again for the useful PR, it makes everything combine really nicely with Cloud Monitoring since the changes! |
Fixes #673 🦕
Fixes #125 🦕
For GKE, we infer the following after thorough discussion and research:
pod_name
==process.env.HOSTNAME
namespace_name
== fs/readfile()~/var/run/secrets/kubernetes.io/serviceaccount/namespace
container_name
is only populated if users pass it into containers as an environment variable. Not available via any downwards APIs or GCP apis for now.Passing e2e environment tests that verify logging behavior in respective platforms: