Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow unformatted originalURL input #1100

Merged
merged 1 commit into from
Jun 14, 2021
Merged

fix: allow unformatted originalURL input #1100

merged 1 commit into from
Jun 14, 2021

Conversation

freelerobot
Copy link
Contributor

@freelerobot freelerobot commented Jun 14, 2021

Fixes: googleapis/nodejs-logging-winston#607

Allows users to input invalid or badly formatted originalUrl values. As it did previously.

@freelerobot freelerobot requested review from a team as code owners June 14, 2021 09:07
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging API. label Jun 14, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2021
@freelerobot freelerobot self-assigned this Jun 14, 2021
@freelerobot freelerobot added the automerge Merge the pull request once unit tests and other checks pass. label Jun 14, 2021
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 14, 2021
@simonz130 simonz130 added the automerge Merge the pull request once unit tests and other checks pass. label Jun 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 136f90b into master Jun 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix607 branch June 14, 2021 20:04
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/nodejs-logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
2 participants