Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log a warning instead of failing test #1161

Merged
merged 1 commit into from
Sep 24, 2021
Merged

fix: log a warning instead of failing test #1161

merged 1 commit into from
Sep 24, 2021

Conversation

minherz
Copy link
Contributor

@minherz minherz commented Sep 23, 2021

Handle flaky tests that fail due deleting non-existing objects.

Fixes #1151

@minherz minherz requested review from a team as code owners September 23, 2021 09:48
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging API. label Sep 23, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2021
@minherz minherz merged commit 689ffb8 into main Sep 24, 2021
@minherz minherz deleted the minherz/fix-1151 branch September 24, 2021 07:53
@bcoe
Copy link
Contributor

bcoe commented Sep 24, 2021

@minherz thanks for taking this on 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/nodejs-logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging: "after all" hook in "Logging" failed
4 participants