Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build!: update library to use Node 12 #1272

Merged
merged 7 commits into from
May 18, 2022
Merged

build!: update library to use Node 12 #1272

merged 7 commits into from
May 18, 2022

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented May 10, 2022

Migrate library to Node 12

@sofisl sofisl requested review from a team as code owners May 10, 2022 17:35
@generated-files-bot
Copy link

generated-files-bot bot commented May 10, 2022 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • .kokoro/continuous/node10/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: logging Issues related to the googleapis/nodejs-logging API. labels May 10, 2022
@losalex losalex assigned losalex and unassigned daniel-sanche May 10, 2022
This was referenced May 10, 2022
Closed
Closed
@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 17, 2022
@sofisl sofisl merged commit 13f909f into main May 18, 2022
@sofisl sofisl deleted the migrateToNode12 branch May 18, 2022 17:39
@release-please release-please bot mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losalex losalex losalex approved these changes

@bcoe bcoe bcoe approved these changes

Assignees

@losalex losalex

Labels
api: logging Issues related to the googleapis/nodejs-logging API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sofisl @bcoe @losalex @daniel-sanche @yoshi-kokoro