Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add test for x-goog-api-client header #556

Merged
merged 3 commits into from
Aug 17, 2019
Merged

fix: add test for x-goog-api-client header #556

merged 3 commits into from
Aug 17, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Aug 16, 2019

adds a test for the x-goog-api-client-header being populated, the fix for process.version has already been landed and just needs to be deployed (I made the change manually so that this passes).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 16, 2019
@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #556 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #556   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files          10       10           
  Lines         431      431           
  Branches       55       55           
=======================================
  Hits          419      419           
  Partials       12       12
Impacted Files Coverage Δ
src/index.ts 95.43% <ø> (ø) ⬆️
src/log.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 808a24b...6741af6. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit f2cd5ea into master Aug 17, 2019
@stephenplusplus stephenplusplus deleted the x-goog branch February 13, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants