Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move ts target to es2018 from es2016 #825

Merged
merged 2 commits into from
Jun 10, 2020
Merged

feat: move ts target to es2018 from es2016 #825

merged 2 commits into from
Jun 10, 2020

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/9b55eba7-85ee-48d5-a737-8b677439db4d/targets

  • To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@1c92077

@yoshi-automation
changes without context
ccef014 
        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
@yoshi-automation
feat(secrets): begin migration to secret manager from keystore
206754e 
Source-Author: Benjamin E. Coe <bencoe@google.com>
Source-Date: Mon Jun 8 09:51:11 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 1c92077459db3dc50741e878f98b08c6261181e0
Source-Link: googleapis/synthtool@1c92077
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 9, 2020
@codecov
Copy link

codecov bot commented Jun 9, 2020 •
edited
Loading

Codecov Report

Merging #825 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #825   +/-   ##
=======================================
  Coverage   97.70%   97.71%           
=======================================
  Files          16       16           
  Lines       10784    10805   +21     
  Branches      401      383   -18     
=======================================
+ Hits        10537    10558   +21     
  Misses        245      245           
  Partials        2        2
Impacted Files Coverage Δ
src/v2/config_service_v2_client.ts 98.61% <100.00%> (+<0.01%) ⬆️
src/v2/logging_service_v2_client.ts 98.46% <100.00%> (+<0.01%) ⬆️
src/v2/metrics_service_v2_client.ts 98.19% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f1d18e...206754e. Read the comment docs.

@bcoe bcoe changed the title feat(secrets): begin migration to secret manager from keystore feat: move ts target to es2018 from es2016 Jun 10, 2020
@bcoe bcoe added the automerge Merge the pull request once unit tests and other checks pass. label Jun 10, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8b73243 into master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees

@sofisl sofisl

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement. context: partial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoshi-automation @bcoe @googlebot @sofisl