Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: update to latest version of gts/typescript #171

Merged
merged 2 commits into from
Mar 24, 2020

Conversation

AVaksman
Copy link
Contributor

BREAKING CHANGE: typescript@3.7 introduced some breaking changes

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2020
@AVaksman AVaksman requested a review from bcoe March 24, 2020 19:45
@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 24, 2020
@bcoe bcoe added the automerge Merge the pull request once unit tests and other checks pass. label Mar 24, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 30f90cc into googleapis:master Mar 24, 2020
"gts": "2.0.0-alpha.5",
"mocha": "^7.1.1",
"c8": "^7.1.0",
"typescript": "3.8.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use ^3.8.3 here?
@bcoe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants