Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: drop Node 8 from engines field #172

Merged
merged 1 commit into from
Mar 24, 2020
Merged

feat!: drop Node 8 from engines field #172

merged 1 commit into from
Mar 24, 2020

Conversation

AVaksman
Copy link
Contributor

Drops Node 8 from the engines field.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2020
@AVaksman AVaksman changed the title feat! drop Node 8 from engines field feat!: drop Node 8 from engines field Mar 24, 2020
@AVaksman AVaksman requested a review from bcoe March 24, 2020 19:45
bcoe
bcoe approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I'm in the process of performing the gts conversion, and will have a PR in a moment.

@bcoe bcoe merged commit 3eac424 into googleapis:master Mar 24, 2020
@release-please release-please bot mentioned this pull request Mar 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AVaksman @bcoe @googlebot