From 97fd4f041c195e0388b0613b2cf9710b89ab4e15 Mon Sep 17 00:00:00 2001
From: Megan Potter <57276408+feywind@users.noreply.github.com>
Date: Wed, 18 Aug 2021 22:08:25 -0400
Subject: [PATCH] fix: don't require a `data` attribute to be passed when
 sending a message (#1370)

Fixes https://github.com/googleapis/nodejs-pubsub/issues/1363

We chatted about this and came to the conclusion that the Node library is probably just wrong here.
---
 src/publisher/index.ts  | 14 ++++++++++++--
 test/publisher/index.ts | 12 ++++++++++++
 2 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/src/publisher/index.ts b/src/publisher/index.ts
index ef169e086..3378e16a4 100644
--- a/src/publisher/index.ts
+++ b/src/publisher/index.ts
@@ -154,11 +154,21 @@ export class Publisher {
   publishMessage(message: PubsubMessage, callback: PublishCallback): void {
     const {data, attributes = {}} = message;
 
-    if (!(data instanceof Buffer)) {
+    // We must have at least one of:
+    //   - `data` as a Buffer
+    //   - `attributes` that are not empty
+    if (data && !(data instanceof Buffer)) {
       throw new TypeError('Data must be in the form of a Buffer.');
     }
 
-    for (const key of Object.keys(attributes!)) {
+    const keys = Object.keys(attributes!);
+    if (!data && keys.length === 0) {
+      throw new TypeError(
+        'If data is undefined, at least one attribute must be present.'
+      );
+    }
+
+    for (const key of keys) {
       const value = attributes![key];
       if (typeof value !== 'string') {
         throw new TypeError(`All attributes must be in the form of a string.
diff --git a/test/publisher/index.ts b/test/publisher/index.ts
index 4d410e0ea..04319b8e5 100644
--- a/test/publisher/index.ts
+++ b/test/publisher/index.ts
@@ -243,6 +243,18 @@ describe('Publisher', () => {
       );
     });
 
+    it('should throw an error if data and attributes are both empty', () => {
+      assert.throws(
+        () => publisher.publishMessage({}, spy),
+        /at least one attribute must be present/
+      );
+    });
+
+    it('should allow sending only attributes', () => {
+      const attributes = {foo: 'bar'} as {};
+      assert.doesNotThrow(() => publisher.publishMessage({attributes}, spy));
+    });
+
     it('should throw an error if attributes are wrong format', () => {
       const attributes = {foo: {bar: 'baz'}} as {};