Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove eslint, update gax, fix generated protos, run the generator #955

Merged
merged 2 commits into from
Apr 11, 2020

Conversation

alexander-fenster
Copy link
Contributor

Run the latest version of the generator, update google-gax, update gts, and remove direct dependencies on eslint.

Run the latest version of the generator, update google-gax, update gts, and remove direct dependencies on eslint.
@alexander-fenster alexander-fenster requested a review from bcoe April 11, 2020 00:41
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 11, 2020
@codecov
Copy link

codecov bot commented Apr 11, 2020

Codecov Report

Merging #955 into master will decrease coverage by 0.03%.
The diff coverage is 94.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #955      +/-   ##
==========================================
- Coverage   94.08%   94.04%   -0.04%     
==========================================
  Files          23       23              
  Lines       10662    10659       -3     
  Branches      522      503      -19     
==========================================
- Hits        10031    10024       -7     
- Misses        628      632       +4     
  Partials        3        3              
Impacted Files Coverage Δ
src/lease-manager.ts 100.00% <ø> (ø)
src/subscriber.ts 99.78% <ø> (-0.01%) ⬇️
src/helper.ts 64.50% <66.66%> (-0.12%) ⬇️
src/index.ts 95.54% <66.66%> (-0.67%) ⬇️
src/message-queues.ts 99.59% <100.00%> (+<0.01%) ⬆️
src/message-stream.ts 98.21% <100.00%> (-0.51%) ⬇️
src/publisher/index.ts 58.87% <100.00%> (ø)
src/publisher/message-queues.ts 50.00% <100.00%> (ø)
src/publisher/publish-error.ts 44.00% <100.00%> (+0.75%) ⬆️
src/pubsub.ts 99.50% <100.00%> (+<0.01%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fc68ba...d80f687. Read the comment docs.

@JustinBeckwith JustinBeckwith added the automerge Merge the pull request once unit tests and other checks pass. label Apr 11, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

2 similar comments
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green gcf-merge-on-green bot merged commit 544a061 into master Apr 11, 2020
@stephenplusplus stephenplusplus deleted the total-regeneration branch August 10, 2020 17:34
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants