Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export publish and subscribe options #1371

Merged
merged 2 commits into from
Aug 18, 2021

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented Aug 10, 2021

Fixes #1227

Some of the options objects that are passed down deep don't have all of the types exposed, so users of TypeScript can't set them gracefully.

@feywind feywind requested review from a team as code owners August 10, 2021 21:38
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Aug 10, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 10, 2021
Copy link
Contributor

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New export is normally considered a feat: IIRC. Other than that, LGTM!

@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 13, 2021
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2021
@feywind feywind added automerge Merge the pull request once unit tests and other checks pass. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Aug 18, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit c37e0fd into googleapis:master Aug 18, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export types for publish/subscriber options
3 participants