Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync to googleapis/conformance-tests@fa559a1 #1167

Merged
merged 10 commits into from
May 4, 2020

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Apr 27, 2020

Updated conformance-tests to reflect signing bucket name into fields.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2020
@jkwlui jkwlui requested a review from frankyn April 27, 2020 23:04
@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #1167 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1167   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files          12       12           
  Lines       11453    11456    +3     
  Branches      525      525           
=======================================
+ Hits        11361    11364    +3     
  Misses         92       92           
Impacted Files Coverage Δ
src/file.ts 99.94% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f72082d...01efad8. Read the comment docs.

@frankyn
Copy link
Member

frankyn commented May 1, 2020

This will fail until #1168 is merged.

* fix(v4-policy): add missing bucket field

* remove bucket from fields

* fix tests
@frankyn frankyn merged commit 5500446 into master May 4, 2020
@stephenplusplus stephenplusplus deleted the conformance-test-bucket branch August 10, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants