Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better defaults for file.save #131

Closed
calvinmetcalf opened this issue Feb 7, 2018 · 4 comments
Closed

better defaults for file.save #131

calvinmetcalf opened this issue Feb 7, 2018 · 4 comments
Assignees
Labels
api: storage Issues related to the googleapis/nodejs-storage API. type: question Request for information or clarification. Not an issue.

Comments

@calvinmetcalf
Copy link
Contributor

file.save should probably default to {resumable: false}, as far as I know resumablility is not going to give any benefit to uploading files in single chunks but can have some performance penalties. In a test I wrote where I had to upload 100 small text files turning resumability off speed the test up from over a minute to a couple seconds.

@stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus added type: question Request for information or clarification. Not an issue. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 7, 2018
@calvinmetcalf
Copy link
Contributor Author

at the very least improving the documentation to make it clear that this setting is available and should be turned off.

@stephenplusplus
Copy link
Contributor

We have a blurb about it in the method description here: https://cloud.google.com/nodejs/docs/reference/storage/1.4.x/File.html#createWriteStream

But the docs are very broken in that none of the options to a method are documented. We have an issue about that here: googleapis/google-cloud-node#2783

@stephenplusplus
Copy link
Contributor

Ah, noticed you're using save. We could add the same note in the method description, or let the fix for googleapis/google-cloud-node#2783 show that resumable exists.

@ghost ghost assigned stephenplusplus Feb 16, 2018
@ghost ghost removed the priority: p2 Moderately-important priority. Fix may not be included in next release. label Feb 16, 2018
@google-cloud-label-sync google-cloud-label-sync bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

2 participants