Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Some Types #2257

Closed
hspak opened this issue Aug 4, 2023 · 1 comment · Fixed by #2258
Closed

Missing Some Types #2257

hspak opened this issue Aug 4, 2023 · 1 comment · Fixed by #2258
Assignees
@ddelgrosso1
Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@hspak
Copy link

hspak commented Aug 4, 2023

Environment details

  • OS: macOS 13.5.
  • Node.js version: 18.16.0
  • npm version: 9.5.1
  • @google-cloud/storage version: 6.10.1 / 7.0.0

Steps to reproduce

  1. Try to use any of the lifecycle related types from bucket.ts, e.g LifecycleRule or LifecycleAction.
  2. Get type error saying it doesn't exist.

It appears we're not exporting these in the index file: https://github.com/googleapis/nodejs-storage/blob/main/src/index.ts
@hspak hspak added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 4, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Aug 4, 2023
@ddelgrosso1 ddelgrosso1 self-assigned this Aug 7, 2023
@ddelgrosso1 ddelgrosso1 mentioned this issue Aug 7, 2023
Merged
4 tasks
@ddelgrosso1
Copy link
Contributor

Thanks @hspak raising a PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddelgrosso1 ddelgrosso1

Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: export new types from index.ts ddelgrosso1/nodejs-storage
2 participants
@hspak @ddelgrosso1