-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow setting contentEncoding during compose #2431
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
57a2d92
to
2d458db
Compare
Thanks for the contribution @zuozp8. It looks like the test
needs to be updated. |
2d458db
to
2f6c03c
Compare
@ddelgrosso1 sure, I updated the test I made sure my |
@ddelgrosso1 linter wants to change files that I didn't touch, should i change them? wouldn't it be better to commit |
@zuozp8 don't worry about them, I have another PR open that will fix them. As a general rule, we don't normally commit package locks but sometimes this is the outcome 😆 |
Thanks again for the contribution @zuozp8. I will get this merged / released after Cloud Next is over. |
Fixes #2430