Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The system tests, they are a flakin' #445

Closed
JustinBeckwith opened this issue Oct 12, 2018 · 1 comment
Closed

The system tests, they are a flakin' #445

JustinBeckwith opened this issue Oct 12, 2018 · 1 comment
Assignees
@jkwlui
Labels
api: storage Issues related to the googleapis/nodejs-storage API. type: cleanup An internal cleanup or hygiene concern.

Comments

@JustinBeckwith
Copy link
Contributor

The system tests are flaky right now. This is an example of a flake:
https://circleci.com/gh/googleapis/nodejs-storage/9385
@JustinBeckwith JustinBeckwith added priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. labels Oct 12, 2018
@JustinBeckwith JustinBeckwith mentioned this issue Oct 12, 2018
Closed
@jkwlui
Copy link
Member

jkwlui commented Oct 17, 2018

I think some of these failures are because of a similar issue we had with nodejs-spanner where we removed all resources across tests assuming only one run of the system test executes at any time.

@jkwlui jkwlui self-assigned this Oct 17, 2018
@jkwlui jkwlui mentioned this issue Oct 18, 2018
Merged
@ghost ghost removed the priority: p2 Moderately-important priority. Fix may not be included in next release. label Oct 18, 2018
@google-cloud-label-sync google-cloud-label-sync bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkwlui jkwlui

Labels
api: storage Issues related to the googleapis/nodejs-storage API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JustinBeckwith @jkwlui