Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save reports 403 after upgrading from 2.5.0 to 3.0.1 #748

Closed
1 task
jcjones1515 opened this issue Jun 14, 2019 · 3 comments · Fixed by googleapis/google-auth-library-nodejs#735
Closed
1 task
Assignees
Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p0 Highest priority. Critical issue. P0 implies highest priority. status: blocked Resolving the issue is dependent on other work.

Comments

@jcjones1515
Copy link

jcjones1515 commented Jun 14, 2019

Blocked


Environment details

  • OS: Google Cloud Functions
  • Node.js version: 8
  • npm version:
  • @google-cloud/storage version: 3.0.1

Steps to reproduce

  1. Upgrade to 3.0.1
  2. Code makes a save call on a GCS file object
  3. Fails with this message:

{ errors: [ { domain: 'global', reason: 'insufficientPermissions', message: 'Insufficient Permission' } ], code: 403, message: 'Insufficient Permission' }

After upgrading to 3.0.1 my Google Cloud Function started getting this on trying to save a file via File.save. I am providing a content type and a few metadata fields in the call. Seems to work just fine with 2.5.0, but upon upgrading to 3.0.1 it starting giving me a 403. If I revert back to 2.5.0 it starts working again.

Sorry I don't have more detail than that.

@jcjones1515 jcjones1515 changed the title save report 403 after upgrading from 2.5.0 to 3.0.1 save reports 403 after upgrading from 2.5.0 to 3.0.1 Jun 14, 2019
@bcoe bcoe added the priority: p0 Highest priority. Critical issue. P0 implies highest priority. label Jun 14, 2019
@bcoe
Copy link
Contributor

bcoe commented Jun 14, 2019

@jcjones1515 to help us isolate a reproduction, mind sharing the extension of the file, and the metadata fields as well if possible?

@jcjones1515
Copy link
Author

content type is application/pdf (extension is .pdf) and the metadata is 4 keys with very simple string and one key with stringified JSON.

@stephenplusplus
Copy link
Contributor

@jcjones1515 sorry for the trouble. The team has removed 3.0.1 from npm and rolled back the latest tag, so that new installs of @google-cloud/storage will not use the broken version.

I've found the issue and have sent a PR with a proposal for a fix: googleapis/google-auth-library-nodejs#735

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jun 16, 2019
@google-cloud-label-sync google-cloud-label-sync bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p0 Highest priority. Critical issue. P0 implies highest priority. status: blocked Resolving the issue is dependent on other work.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants