Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

feat(samples): add samples and tests for adding captions to videos #143

Merged
merged 2 commits into from
Jan 12, 2022
Merged

feat(samples): add samples and tests for adding captions to videos #143

merged 2 commits into from
Jan 12, 2022

Conversation

irataxy
Copy link
Contributor

@irataxy irataxy commented Jan 11, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b:210892114

@irataxy irataxy requested a review from a team as a code owner January 11, 2022 22:41
@snippet-bot
Copy link

snippet-bot bot commented Jan 11, 2022

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: transcoder Issues related to the googleapis/nodejs-video-transcoder API. samples Issues that are directly related to samples. labels Jan 11, 2022
@irataxy irataxy added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2022
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My only concern with tests that create resources (which I'm sure I've mentioned before 😆) is what happens if a test fails, will we gradually leak the resources?

Could we add an after step that deletes jobs older than N days? Do we do this elsewhere?

@irataxy irataxy merged commit 52ca4ff into googleapis:main Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: transcoder Issues related to the googleapis/nodejs-video-transcoder API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants