This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
feat(samples): delete old test jobs #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
api: transcoder
irataxy
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
bcoe
reviewed
Feb 5, 2022
| @@ -127,6 +127,24 @@ after(async () => { | |||
| } catch (err) { | |||
| console.log('Cannot delete bucket'); | |||
| } | |||
| // Delete outstanding jobs created more than 3 days ago | |||
| const {TranscoderServiceClient} = | |||
There was a problem hiding this comment.
Is there a prefix we can check for as well on job.name? Otherwise I'm worried we might delete resources unintentionally.
There was a problem hiding this comment.
Unfortunately not. The job is a long-running operation where the server assigns a random name.
tmatsuo
approved these changes
Feb 8, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
tmatsuo
pushed a commit
that referenced
this pull request
Feb 8, 2022
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address feedback from @bcoe in #143 (review)
Fixes 214389318