Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

Implement Decorator 3LO pattern for Flask #224

Closed
anthmgoogle opened this issue Jul 22, 2015 · 3 comments · Fixed by #226
Closed

Implement Decorator 3LO pattern for Flask #224

anthmgoogle opened this issue Jul 22, 2015 · 3 comments · Fixed by #226

Comments

@anthmgoogle
Copy link

The OAuth2Decorator pattern has been implemented for the WebApp2Framework. See the class OAuth2Decorator here:
https://github.com/google/oauth2client/blob/master/oauth2client/appengine.py

This pattern if very effective for usability of 3LO and should be extended to other frameworks. This item tracks implementing this pattern for Flask.

@anthmgoogle anthmgoogle changed the title Implement Decorator 3LO patterm for Flask Implement Decorator 3LO pattern for Flask Jul 22, 2015
@frederikcreemers
Copy link
Contributor

Should separate modules be craeted for flask, bottle etc in the oauth2client directory? Or would we create an integrations module that contains all of this?

@dhermes
Copy link
Contributor

dhermes commented Jul 23, 2015

I vote (strongly) for separate modules.

I also vote for approaching this as an opportunity to think about extensibility. In other words, make it so that it's clear and easy for someone to build such an extension (maybe even just build this as extension libraries, e.g. requests-oauthlib).

@theacodes
Copy link
Contributor

I'm working on this, as I have existing sample code that mostly does this. I'll submit a PR shortly and we can continue discussion there as we flesh this out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants