fix: third party enums don't break first class enums #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 811 857 +46
Branches 136 149 +13
=========================================
+ Hits 811 857 +46
Continue to review full report at Codecov.
|
|
Python-dlp passes all unit tests using both the python and cpp implementations. |
For real, this time. Third party, unwrapped enums no longer cause problems if they are used to describe proto-plus fields. Limitations: * Third party enums cannot be passed by string name to a Field * More scenarios require a module definition than previously ** Defining a proto.Enum may cause a FileDescriptor to be added to the descriptor pool. The only way to defer until _all_ Enums and Messages in a module have been added is to provide a manifest or make the Enum a nested type of a Message. This mostly affects unit tests and interactive development. Includes re-addition of stringy enums in JSON. Includes re-addition of fix for #103 Release-As: 1.10.0-dev1
lukesneeringer
approved these changes
Sep 10, 2020
busunkim96
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For real, this time.
Third party, unwrapped enums no longer cause problems
if they are used to describe proto-plus fields.
Limitations:
Third party enums cannot be passed by string name to a Field
More scenarios require a module definition than previously
** Defining a proto.Enum may cause a FileDescriptor to be added to the
descriptor pool. The only way to defer until all Enums and
Messages in a module have been added is to provide a manifest or
make the Enum a nested type of a Message.
This mostly affects unit tests and interactive development.
Includes re-addition of stringy enums in JSON.
Includes re-addition of fix for #103
Release-As: 1.10.0-dev1