Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 3.9 support and drop 3.5 #167

Merged
merged 15 commits into from
Dec 4, 2020
Merged

feat: add 3.9 support and drop 3.5 #167

merged 15 commits into from
Dec 4, 2020

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Dec 4, 2020

@busunkim96 busunkim96 requested a review from a team as a code owner December 4, 2020 00:56
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 4, 2020
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #167 (80802db) into master (5c14cba) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #167   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          862       862           
  Branches       149       149           
=========================================
  Hits           862       862           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c14cba...80802db. Read the comment docs.

@busunkim96 busunkim96 changed the title chore: add constraints file chore: add constraints file and 3.9 tests Dec 4, 2020
@busunkim96 busunkim96 changed the title chore: add constraints file and 3.9 tests feat: add 3.9 support and drop 3.5 Dec 4, 2020
@busunkim96
Copy link
Contributor Author

3.9 failures looks legitimate. Does some extra package need to be installed? @software-dov

https://app.circleci.com/pipelines/github/googleapis/proto-plus-python/409/workflows/059ae846-628f-498d-a500-68ca5ba92dca/jobs/3647/parallel-runs/0/steps/0-103?invite=true

nox > Running session unitcpp-3.9
nox > Creating virtual environment (virtualenv) using python3.9 in .nox/unitcpp-3-9
nox > pip install coverage pytest pytest-cov pytz
nox > pip install -e .[testing] -c /root/project/testing/constraints-3.9.txt
nox > py.test -W=error --quiet --cov=proto --cov-config=.coveragerc --cov-report=term --cov-report=html tests/
ImportError while loading conftest '/root/project/tests/conftest.py'.
tests/conftest.py:18: in <module>
    from google.protobuf import descriptor_pool
.nox/unitcpp-3-9/lib/python3.9/site-packages/google/protobuf/descriptor_pool.py:63: in <module>
    from google.protobuf import descriptor
.nox/unitcpp-3-9/lib/python3.9/site-packages/google/protobuf/descriptor.py:48: in <module>
    from google.protobuf.pyext import _message
E   ImportError: cannot import name '_message' from 'google.protobuf.pyext' (/root/project/.nox/unitcpp-3-9/lib/python3.9/site-packages/google/protobuf/pyext/__init__.py)
nox > Command py.test -W=error --quiet --cov=proto --cov-config=.coveragerc --cov-report=term --cov-report=html tests/ failed with exit code 4
nox > Session unitcpp-3.9 failed.

@software-dov
Copy link
Contributor

I ran into a similar problem when I initially tried running with 3.9; my best guess is that it's indicative of missing 3.9-specific protobuf C++ libs. We should double check with the python protobuf folks to see if that is an artifact that needs to be released.

@busunkim96
Copy link
Contributor Author

Looks like wheels are not yet published for 3.9. protocolbuffers/protobuf#7978

https://pypi.org/project/protobuf/3.14.0/#files has up through 3.8.

@busunkim96
Copy link
Contributor Author

I commented out the 3.9 C++ session for now.

@busunkim96 busunkim96 merged commit 6d17195 into master Dec 4, 2020
@busunkim96 busunkim96 deleted the add-constraints-file branch December 4, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants