-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add 3.9 support and drop 3.5 #167
Conversation
busunkim96
commented
Dec 4, 2020
•
edited
Loading
edited
- Drop 3.5 which is now EOL. https://www.python.org/downloads/release/python-3510/
- Add 3.9 tests and make them required.
- Add a constraints file and use it to test lower bounds in the setup.py in one unit test session (3.6)
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 862 862
Branches 149 149
=========================================
Hits 862 862 Continue to review full report at Codecov.
|
3.9 failures looks legitimate. Does some extra package need to be installed? @software-dov
|
I ran into a similar problem when I initially tried running with 3.9; my best guess is that it's indicative of missing 3.9-specific protobuf C++ libs. We should double check with the python protobuf folks to see if that is an artifact that needs to be released. |
Looks like wheels are not yet published for 3.9. protocolbuffers/protobuf#7978 https://pypi.org/project/protobuf/3.14.0/#files has up through 3.8. |
I commented out the 3.9 C++ session for now. |
🤖 I have created a release \*beep\* \*boop\* --- ## [1.13.0](https://www.github.com/googleapis/proto-plus-python/compare/v1.12.0...v1.13.0) (2020-12-04) ### Features * add 3.9 support and drop 3.5 ([#167](https://www.github.com/googleapis/proto-plus-python/issues/167)) ([6d17195](https://www.github.com/googleapis/proto-plus-python/commit/6d171956e14b398aece931b9dde1013be9644b74)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).