fix: proper __setitem__ and insert for RepeatedComposite #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 862 881 +19
Branches 149 159 +10
=========================================
+ Hits 862 881 +19
Continue to review full report at Codecov.
|
software-dov
approved these changes
Feb 10, 2021
Satiate style check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #177; please refer to the issue for context.
The proposed solution is not elegant at all, but might be the best in the short term until the underlying protocol buffer object supports the
__setitem__method.Nota bene: the underlying
RepeatedCompositeFieldContainerfromgoogle.protobuf.internal.containersalready supports theinsertmethod, and we only need to perform type conversion for this particular case.