feat: allow_alias for enums #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
software-dov
requested review from
vchudnov-g,
busunkim96,
arithmetic1728 and
a team
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 862 886 +24
Branches 149 160 +11
=========================================
+ Hits 862 886 +24
Continue to review full report at Codecov.
|
Certain APIs, e.g. recommendationengine, have enums where variants are aliased, i.e. different names map to the same integer value. Allowing this behavior in proto plus for the cpp protobuf runtime requires constructing and passing the correct options.
software-dov
force-pushed
the
enum-alias
branch
from
69b96fa to
0224635
Compare
|
Partial fix for #159 |
busunkim96
approved these changes
Mar 10, 2021
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain APIs, e.g. recommendationengine, have enums where variants are
aliased, i.e. different names map to the same integer value.
Allowing this behavior in proto plus for the cpp protobuf runtime
requires constructing and passing the correct options.