Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add no-pretty print option #336

Merged
merged 3 commits into from
Aug 29, 2022
Merged

Conversation

vam-google
Copy link
Contributor

This fixes #284 and in general makes sense.

This fixes googleapis#284 and in general  makes sense.
@vam-google vam-google requested review from a team as code owners August 27, 2022 00:09
@vam-google vam-google changed the title fix: Add no-pretty perint option fix: Add no-pretty print option Aug 27, 2022
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if we can address new lines also: #284 (comment)

@vam-google
Copy link
Contributor Author

@parthea The new lines have been addressed originally. I've responded to thebug and also improved the documentation to make it clear that indent=None means no new lines.

@vam-google vam-google merged commit 1bb228a into googleapis:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to_json option to exclude newline
3 participants