-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve issue where marshal fails with cross api dependency #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
force-pushed
the
fix-cross-api-dependency
branch
from
March 15, 2023 12:00
aed6ea9
to
e123ad8
Compare
parthea
changed the title
[WIP] fix: resolve issue where marshal fails with cross api dependency
fix: resolve issue where marshal fails with cross api dependency
Mar 15, 2023
parthea
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Mar 15, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Mar 15, 2023
parthea
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Mar 15, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Mar 15, 2023
parthea
force-pushed
the
fix-cross-api-dependency
branch
from
March 15, 2023 12:24
7a921ea
to
0df6e02
Compare
parthea
force-pushed
the
fix-cross-api-dependency
branch
from
March 15, 2023 12:26
0df6e02
to
8f6b7b5
Compare
parthea
added
the
status: blocked
Resolving the issue is dependent on other work.
label
Mar 16, 2023
Waiting for approval on go/proto-plus-cross-api-issue |
This was referenced Apr 15, 2023
atulep
approved these changes
May 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vchudnov-g
approved these changes
Jun 8, 2023
This was referenced Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #349
Fixes googleapis/python-gke-hub#151
Googlers see go/proto-plus-cross-api-issue