Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize insert for class RepeatedComposite. #95

Merged
merged 3 commits into from
Aug 7, 2020
Merged

feat: optimize insert for class RepeatedComposite. #95

merged 3 commits into from
Aug 7, 2020

Conversation

bobhancock
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2020
@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #95 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #95   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          811       808    -3     
  Branches       136       135    -1     
=========================================
- Hits           811       808    -3     
Impacted Files Coverage Δ
proto/marshal/collections/repeated.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc28bbb...0417214. Read the comment docs.

Use a standard Python list insert on the target list
to replace a loop using pop and extend.
@software-dov software-dov changed the title Optimize insert for class RepeatedComposite. feat: optimize insert for class RepeatedComposite. Aug 7, 2020
@software-dov software-dov merged commit 86790e3 into googleapis:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants