Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow base64 encoded credentials in URI #410

Merged
merged 9 commits into from
Feb 17, 2022
Merged

feat: Allow base64 encoded credentials in URI #410

merged 9 commits into from
Feb 17, 2022

Conversation

AlbertDeFusco
Copy link
Contributor

@AlbertDeFusco AlbertDeFusco commented Feb 4, 2022 •
edited
Loading

Fixes #409 🦕 To enable credential information to be included in the connection URL, for cases where you don't have a credentials file locally on the client, I propose the credentials_base64 parameter. It requires that the user have encoded their credentials JSON file using a number of techniques like base64, or openssl base64, or python -m base64, or www.base64encode.org.

I have used nox to run unit and system tests for Python 3.6 - 3.9. I'm tracking down a separate issue with my computer for why 3.10 tests did not run.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@AlbertDeFusco AlbertDeFusco requested a review from a team February 4, 2022 22:07
@AlbertDeFusco AlbertDeFusco requested a review from a team as a code owner February 4, 2022 22:07
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Feb 4, 2022
@AlbertDeFusco AlbertDeFusco changed the title Allow base64 encoded credentials in URI feat: Allow base64 encoded credentials in URI Feb 5, 2022
@shollyman shollyman requested review from tswast and removed request for shollyman February 5, 2022 22:37
@tswast tswast added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 14, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 14, 2022
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 17, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 17, 2022
@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Feb 17, 2022
@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 17, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 17, 2022
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 17, 2022
tswast
tswast approved these changes Feb 17, 2022
View reviewed changes
tests/unit/test_helpers.py Outdated Show resolved Hide resolved
tests/unit/test_helpers.py Outdated Show resolved Hide resolved
@tswast tswast added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 17, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 17, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit e2f9821 into googleapis:main Feb 17, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 17, 2022
@release-please release-please bot mentioned this pull request Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow base64 encoded credentials in URL
3 participants
@AlbertDeFusco @tswast @yoshi-kokoro