Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: pass credentials as python dictionary #737

Merged

Conversation

alvarowolfx
Copy link
Contributor

Document how to pass the credentials directly as dictionary/json instead of key json file path.

Fixes #331 🦕

@alvarowolfx alvarowolfx requested a review from a team as a code owner January 26, 2023 15:36
@alvarowolfx alvarowolfx requested a review from a team January 26, 2023 15:36
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Jan 26, 2023
@alvarowolfx alvarowolfx added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 6, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 6, 2023
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@alvarowolfx
Copy link
Contributor Author

@chalmerlowe thanks for the review. I agree your recommendations and updated the PR accordingly.

Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarowolfx alvarowolfx added the automerge Merge the pull request once unit tests and other checks pass. label Feb 8, 2023
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 8, 2023
@meredithslota meredithslota added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 9, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 9, 2023
@meredithslota meredithslota added the automerge Merge the pull request once unit tests and other checks pass. label Feb 9, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 074321d into googleapis:main Feb 9, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we pass the credentials directly as dictionary/json instead of key json file path?
5 participants