Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure repo install #741

Merged
merged 16 commits into from
Feb 1, 2023
Merged

fix: Ensure repo install #741

merged 16 commits into from
Feb 1, 2023

Conversation

chalmerlowe
Copy link
Collaborator

Fixes logic to ensure that this repo is always installed (either from source OR from PyPI when running samples tests).

Without the logic, this only attempts to install this repo from source under specific circumstances. If those circumstances were not True, then the repo never gets installed and the samples test suite fails completely.

@chalmerlowe chalmerlowe requested a review from a team as a code owner February 1, 2023 13:44
@chalmerlowe chalmerlowe requested a review from a team February 1, 2023 13:44
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Feb 1, 2023
@product-auto-label product-auto-label bot added size: u Pull request is empty. and removed size: xs Pull request size is extra small. labels Feb 1, 2023
@chalmerlowe chalmerlowe requested a review from a team as a code owner February 1, 2023 15:54
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: u Pull request is empty. labels Feb 1, 2023
@chalmerlowe chalmerlowe merged commit 75ef9ac into main Feb 1, 2023
@chalmerlowe chalmerlowe deleted the ensure-repo-install branch February 1, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants