-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensure repo install #741
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
Pull request size is extra small.
api: bigquery
Issues related to the googleapis/python-bigquery-sqlalchemy API.
labels
Feb 1, 2023
product-auto-label
bot
added
size: u
Pull request is empty.
and removed
size: xs
Pull request size is extra small.
labels
Feb 1, 2023
…gquery-sqlalchemy into ensure-repo-install
product-auto-label
bot
added
size: s
Pull request size is small.
and removed
size: u
Pull request is empty.
labels
Feb 1, 2023
…ython-bigquery-sqlalchemy into ensure-repo-install
…ython-bigquery-sqlalchemy into ensure-repo-install
…ython-bigquery-sqlalchemy into ensure-repo-install
…ython-bigquery-sqlalchemy into ensure-repo-install
leahecole
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquery
Issues related to the googleapis/python-bigquery-sqlalchemy API.
size: s
Pull request size is small.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes logic to ensure that this repo is always installed (either from source OR from PyPI when running samples tests).
Without the logic, this only attempts to install this repo from source under specific circumstances. If those circumstances were not True, then the repo never gets installed and the samples test suite fails completely.