Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(main): clarify importlib import #738

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

xionams
Copy link
Contributor

@xionams xionams commented Feb 2, 2024

add a comment about importlib-metadata compatibility with Python versions and change the name of the package from "importlib_metadata" to "importlib-metadata"

related to #735

@xionams xionams requested review from a team as code owners February 2, 2024 12:33
Copy link

google-cla bot commented Feb 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. labels Feb 2, 2024
@xionams xionams changed the title clarify importlib import #735 fix(main): clarify importlib import Feb 2, 2024
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@Linchin Linchin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 2, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 2, 2024
@Linchin Linchin merged commit 04efdbd into googleapis:main Feb 5, 2024
24 checks passed
@xionams xionams deleted the clarify-importlib-import branch February 5, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants