deps: support OpenTelemetry >= 1.1.0 #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
tswast
approved these changes
Nov 8, 2021
| ) | ||
| except (ImportError, AttributeError) as exc: # pragma: NO COVER | ||
| msg = "Error importing from opentelemetry, is the installed version compatible?" | ||
| raise ImportError(msg) from exc |
There was a problem hiding this comment.
Good call on raising this here. I'd rather we catch incompatibilities early.
tswast
changed the title
abdelmegahedgoogle
pushed a commit
to abdelmegahedgoogle/python-bigquery
that referenced
this pull request
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1038.
This PR makes sure that the tracing logic is compatible with
OpenTelemetry >= 1.1.0(the first version that supports type checks), and that tests actually fail if a futurepython-opentelemetryversion contains backward-incompatible changes in its API (previously the tests would just be skipped).PR checklist: