Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: show common job properties in get_job and cancel_job samples #1137

Merged
merged 2 commits into from
Feb 14, 2022
Merged

docs: show common job properties in get_job and cancel_job samples #1137

merged 2 commits into from
Feb 14, 2022

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Feb 11, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal issue 199162556 🦕

@tswast tswast requested a review from a team February 11, 2022 23:13
@tswast tswast requested review from a team as code owners February 11, 2022 23:13
@product-auto-label product-auto-label bot added api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. labels Feb 11, 2022
@snippet-bot
Copy link

snippet-bot bot commented Feb 11, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@tswast tswast mentioned this pull request Feb 14, 2022
Merged
3 tasks
@tswast tswast merged commit 8edc10d into main Feb 14, 2022
@tswast tswast deleted the b199162556-job_id-sample branch February 14, 2022 22:02
@release-please release-please bot mentioned this pull request Feb 14, 2022
Merged
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@tswast @abdelmegahedgoogle
docs: show common job properties in get_job and cancel_job samples (
7c1a73e 
googleapis#1137)

* docs: show common job properties in `get_job` and `cancel_job` samples

* flake8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@steffnay steffnay Awaiting requested review from steffnay

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tswast @busunkim96