Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigquery): expose start index parameter for query result #121

Merged
merged 2 commits into from
Jun 6, 2020
Merged

feat(bigquery): expose start index parameter for query result #121

merged 2 commits into from
Jun 6, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #120

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2020
plamut
plamut reviewed Jun 4, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just have two improvement comments.

google/cloud/bigquery/job.py Outdated Show resolved Hide resolved
google/cloud/bigquery/job.py Outdated Show resolved Hide resolved
shollyman
shollyman approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@plamut plamut merged commit be86de3 into googleapis:master Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why QueryJob.result() function doesn't support 'start_index' parameter?
4 participants
@HemangChothani @shollyman @plamut @googlebot