Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): allow pyarrow v8 #1245

Merged
merged 1 commit into from
May 9, 2022
Merged

fix(deps): allow pyarrow v8 #1245

merged 1 commit into from
May 9, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented May 9, 2022

No description provided.

@parthea parthea requested a review from a team May 9, 2022 15:01
@parthea parthea requested a review from a team as a code owner May 9, 2022 15:01
@parthea parthea requested a review from prash-mi May 9, 2022 15:01
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels May 9, 2022
@parthea parthea mentioned this pull request May 9, 2022
1 task
@parthea parthea requested a review from meredithslota May 9, 2022 15:36
@leahecole leahecole merged commit d258690 into main May 9, 2022
@leahecole leahecole deleted the allow-pyarrow-v8 branch May 9, 2022 15:49
@bnaul
Copy link
Contributor

bnaul commented May 9, 2022

Sorry to hijack but what's the motivation for always capping the version at whatever is released today? It's a bit frustrating as a user to not be able to use a recently released package because some other dependency has an overly restrictive range of allowed versions. In the opposite case, the user is always free to add say pyarrow<9 to their own requirements.txt if they want, but with the current setup I'm pretty much stuck on waiting on another version bump to get everything working.

Appreciate the quick fix here, just wondering if maybe the current system is more hassle than it's worth.

@meredithslota
Copy link
Contributor

@bnaul The reason that we use this approach is because a new major version of a dependency can break users who do not explicitly restrict them via requirements.txt. We know it is best practice to have a requirements.txt file but not all users do that. In addition, it may take time for our code or samples to be re-written/fixed in order to have compatibility with a new major version, and we'd prefer to err on the side of not accidentally breaking folks. We try to update as soon as possible. Thanks!

waltaskew pushed a commit to waltaskew/python-bigquery that referenced this pull request Jul 20, 2022
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants