-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: created samples for load table and create table from schema file #1436
Conversation
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mattix23 @thejaredchapman We are getting some type checking failures. I've made some suggested edits that might fix this.
nox > Running session mypy_samples
nox > Creating virtual environment (virtualenv) using python3.8 in .nox/mypy_samples
nox > python -m pip install -e '.[all]'
nox > python -m pip install ipython pytest
nox > python -m pip install mypy==0.910
nox > python -m pip install types-mock types-pytz
nox > python -m pip install typing-extensions
nox > mypy --config-file /tmpfs/src/github/python-bigquery/samples/mypy.ini --no-incremental samples/
samples/snippets/load_table_schema_from_json.py:18: error: Function is missing a return type annotation
samples/snippets/load_table_schema_from_json.py:37: error: Incompatible types in assignment (expression has type "Path", variable has type "str")
samples/snippets/create_table_schema_from_json.py:18: error: Function is missing a return type annotation
samples/snippets/create_table_schema_from_json.py:34: error: Incompatible types in assignment (expression has type "Path", variable has type "str")
Found 4 errors in 2 files (checked 212 source files)
nox > Command mypy --config-file /tmpfs/src/github/python-bigquery/samples/mypy.ini --no-incremental samples/ failed with exit code 1
nox > Session mypy_samples failed.
Co-authored-by: Tim Swast <swast@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change, otherwise looking good!
Co-authored-by: Tim Swast <swast@google.com>
googleapis#1436) * docs: created samples for load table and create table from schema file * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Apply suggestions from code review Co-authored-by: Tim Swast <swast@google.com> * Update samples/snippets/create_table_schema_from_json.py Co-authored-by: Tim Swast <swast@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Tim Swast <swast@google.com>
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards #1069 🦕