Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kokoro failing due to mypy_samples #1453

Closed
tswast opened this issue Jan 4, 2023 · 0 comments · Fixed by #1455
Closed

Kokoro failing due to mypy_samples #1453

tswast opened this issue Jan 4, 2023 · 0 comments · Fixed by #1455
Assignees
@tswast @thejaredchapman @Mattix23
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples.

Comments

@tswast
Copy link
Contributor

tswast commented Jan 4, 2023 

nox > mypy --config-file /tmpfs/src/github/python-bigquery/samples/mypy.ini --no-incremental samples/
samples/magics/query_params_scalars.py:26: error: Module has no attribute "get_ipython"
samples/magics/query.py:26: error: Module has no attribute "get_ipython"
samples/magics/conftest.py:21: error: Module "IPython.core.interactiveshell" has no attribute "TerminalInteractiveShell"; maybe "InteractiveShell"?
samples/snippets/jupyter_tutorial_test.py:37: error: Returning Any from function declared to return "TerminalInteractiveShell"
Found 4 errors in 4 files (checked 218 source files)

https://source.cloud.google.com/results/invocations/c82d12de-2c5f-4242-9f1f-57db4c7f950d/targets/cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fpython-bigquery%2Fpresubmit%2Fpresubmit/log
@product-auto-label product-auto-label bot added api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. labels Jan 4, 2023
@tswast tswast mentioned this issue Jan 4, 2023
Merged
4 tasks
@tswast tswast assigned tswast, thejaredchapman and Mattix23 and unassigned tswast Jan 6, 2023
@thejaredchapman thejaredchapman mentioned this issue Jan 6, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tswast tswast

@thejaredchapman thejaredchapman

@Mattix23 Mattix23

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: install all sample dependencies when type checking samples googleapis/python-bigquery
3 participants
@tswast @thejaredchapman @Mattix23