Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support JSON data type in insert_rows and as query parameters #1756

Closed
tswast opened this issue Dec 15, 2023 · 4 comments · Fixed by #1757
Closed

Support JSON data type in insert_rows and as query parameters #1756

tswast opened this issue Dec 15, 2023 · 4 comments · Fixed by #1757
Assignees
@tswast
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tswast
Copy link
Contributor

tswast commented Dec 15, 2023

We need to make sure the JSON data type is supported for insert_rows. I suspect it is broken for query parameters, too.

See: #1587 (comment)
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Dec 15, 2023
@tswast tswast mentioned this issue Dec 15, 2023
Merged
@tswast
Copy link
Contributor Author

tswast commented Dec 15, 2023

I think we need to update:

python-bigquery/google/cloud/bigquery/_helpers.py

Line 442 in fdd580f

"JSON": _json_from_json,

It should be json_to_json and dumps rather than loads.

@tswast
Copy link
Contributor Author

tswast commented Dec 15, 2023

Also, update our insert_rows and query_parameters system tests to use the JSON data type in some column.

@tswast tswast self-assigned this Dec 15, 2023
@tswast tswast added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Dec 15, 2023
@tswast tswast mentioned this issue Dec 15, 2023
Merged
4 tasks
@ekampf
Copy link

ekampf commented Dec 18, 2023

@tswast _json_from_json expects value and field but the code calling it in _scalar_field_to_json calls converter(value) which would always fail...

@tswast
Copy link
Contributor Author

tswast commented Dec 18, 2023

@ekampf You are correct. I fix this in #1757

@bricker bricker mentioned this issue Jan 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tswast tswast

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support JSON type in insert_rows and as a scalar query parameter googleapis/python-bigquery
2 participants
@ekampf @tswast