Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the query with no cache sample to use query_and_wait API #1770

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

SalemJorden
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 11, 2024
Copy link

conventional-commit-lint-gcf bot commented Jan 11, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jan 11, 2024
@SalemJorden SalemJorden changed the title query_no_cache.py updates : Call to API query_no_cache.py code sample updates Jan 11, 2024
@@ -26,7 +26,7 @@ def query_no_cache() -> None:
FROM `bigquery-public-data.samples.shakespeare`
GROUP BY corpus;
"""
query_job = client.query(sql, job_config=job_config) # Make an API request.
query_job = client.query_and_wait(sql, job_config=job_config) # Make an API request.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this variable to results since it is no longer a QueryJob object.

@tswast tswast changed the title query_no_cache.py code sample updates docs: update the query with no cache sample to use query_and_wait API Jan 11, 2024
@tswast tswast marked this pull request as ready for review January 11, 2024 21:29
@tswast tswast requested review from a team as code owners January 11, 2024 21:29
@tswast tswast changed the title docs: update the query with no cache sample to use query_and_wait API docs: update the query with no cache sample to use query_and_wait API Jan 11, 2024
@tswast tswast enabled auto-merge (squash) January 11, 2024 21:30
auto-merge was automatically disabled January 11, 2024 21:52

Head branch was pushed to by a user without write access

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 12, 2024
@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 17, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 17, 2024
@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2024
@chalmerlowe chalmerlowe merged commit 955a4cd into googleapis:main Jan 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants