Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning in the type mapping if no conversion function is found #1988

Closed
suzmue opened this issue Aug 5, 2024 · 0 comments · Fixed by #1989
Closed

Add a warning in the type mapping if no conversion function is found #1988

suzmue opened this issue Aug 5, 2024 · 0 comments · Fixed by #1989
Assignees
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@suzmue
Copy link
Contributor

suzmue commented Aug 5, 2024

Is your feature request related to a problem? Please describe.
Unsupported types are silently handled in order to allow for tables with column types the client library cannot handle yet. Once these types are supported, the returned type for the column is likely to change to reflect the correct handling of the type. However, this may require different code to handle from the user.

See #1587 for an example when support for json values was added.

Describe the solution you'd like
Add a warning to the type mapping when the type does not have a conversion function, since the handling for this type may change:

converter = _CELLDATA_FROM_JSON.get(field.field_type, lambda value, _: value)

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Aug 5, 2024
@suzmue suzmue assigned suzmue and unassigned leahecole Aug 5, 2024
@suzmue suzmue added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants