-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updates to allow users to set max_stream_count #2039
Conversation
Shouldn't |
In the question of which argument overrides which, I could probably be convinced to go either way. I purposely chose for
|
I am also in favor of having preserve_order override the max_streams_count setting. I think this would make it easier to use and understand. If Perhaps an error for when Edit: Actually I don't think the error is necessary for the same reason as why setting to 1 should always be ok. |
let me cogitate on this. thanks for the input, both of you. |
I revised the logic. Once the CI/CD checks pass, can you approve it, Suzy? |
Co-authored-by: Suzy Mueller <suzmue@google.com>
Co-authored-by: Suzy Mueller <suzmue@google.com>
Co-authored-by: Suzy Mueller <suzmue@google.com>
…hon-bigquery into update-maxstreams
…hon-bigquery into update-maxstreams
…hon-bigquery into update-maxstreams
…hon-bigquery into update-maxstreams
Removed unnecessary else statement.
Adds a function `determine_requested_streams()` to compare `preserve_order` and the new argument `max_stream_count` to determine how many streams to request. ``` preserve_order (bool): Whether to preserve the order of streams. If True, this limits the number of streams to one (more than one cannot guarantee order). max_stream_count (Union[int, None]]): The maximum number of streams allowed. Must be a non-negative number or None, where None indicates the value is unset. If `max_stream_count` is set, it overrides `preserve_order`. ``` Fixes #2030 🦕
Adds a function
determine_requested_streams()
to comparepreserve_order
and the new argumentmax_stream_count
to determine how many streams to request.Fixes #2030 🦕