Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow routine references #378

Merged
merged 5 commits into from
Nov 10, 2020
Merged

feat: allow routine references #378

merged 5 commits into from
Nov 10, 2020

Conversation

cguardia
Copy link
Contributor

The Access property of a dataset now allows references to Routine entities.

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #353 🦕

@cguardia cguardia requested review from a team and tswast November 10, 2020 09:39
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 10, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 10, 2020
@cguardia cguardia changed the title 353 allow routine references feat: allow routine references Nov 10, 2020
tswast
tswast approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast tswast merged commit f9480dc into googleapis:master Nov 10, 2020
@cguardia cguardia deleted the 353-allow-routine-references branch November 11, 2020 06:57
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement: Authorized UDF support for dataset Access
2 participants
@cguardia @tswast