Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix Shapely import in GEOGRAPHY sample #431

Merged
merged 1 commit into from
Dec 9, 2020
Merged

docs: fix Shapely import in GEOGRAPHY sample #431

merged 1 commit into from
Dec 9, 2020

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Dec 9, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@tswast tswast requested a review from a team as a code owner December 9, 2020 22:36
@tswast tswast requested review from busunkim96 and removed request for a team December 9, 2020 22:36
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Dec 9, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 9, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 9, 2020
@tswast tswast requested a review from shollyman December 9, 2020 22:36
shollyman
shollyman approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests ok

@tswast tswast merged commit 96a1c5b into googleapis:master Dec 9, 2020
@tswast tswast deleted the b171804665-geography branch December 9, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @shollyman @busunkim96