Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/unit/job/helpers should reuse more code from tests/unit/helpers #922

Closed
jimfulton opened this issue Aug 27, 2021 · 0 comments · Fixed by #940
Closed

tests/unit/job/helpers should reuse more code from tests/unit/helpers #922

jimfulton opened this issue Aug 27, 2021 · 0 comments · Fixed by #940
Assignees
@jimfulton
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: process A process-related concern. May include testing, release, or the like.

Comments

@jimfulton
Copy link
Contributor

#921 gets rid of a superfluous _make_connection function. I'm fairly sure more duplicative functions can be removed.

Note that I kept _make_connection because I didn't want to clutter #921 with a ton of changed calls. Those need to be fixed too.
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Aug 27, 2021
@jimfulton jimfulton self-assigned this Aug 27, 2021
@tswast tswast added the type: process A process-related concern. May include testing, release, or the like. label Aug 27, 2021
@jimfulton jimfulton changed the title tests/unit/job/helpers should reuse more code gtom tests/unit/helpers tests/unit/job/helpers should reuse more code from tests/unit/helpers Aug 27, 2021
@jimfulton jimfulton mentioned this issue Sep 2, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimfulton jimfulton

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Reduce duplicated code betweem tests/unit and tests/unit/job jimfulton/python-bigquery
2 participants
@tswast @jimfulton