From b7c6c819faca9b6613ea0a73ee37e2560ffafd7b Mon Sep 17 00:00:00 2001 From: HemangChothani Date: Tue, 18 Aug 2020 16:49:32 +0530 Subject: [PATCH 1/3] fix: test flakes --- tests/system.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/system.py b/tests/system.py index be79a6d20..2718fef05 100644 --- a/tests/system.py +++ b/tests/system.py @@ -434,7 +434,9 @@ def test_delete_dataset_delete_contents_true(self): dataset_id = _make_dataset_id("delete_table_true") project = Config.CLIENT.project dataset_ref = bigquery.DatasetReference(project, dataset_id) - dataset = retry_403(Config.CLIENT.create_dataset)(Dataset(dataset_ref)) + dataset = retry_403(Config.CLIENT.create_dataset)( + Dataset(dataset_ref), exists_ok=True + ) table_id = "test_table" table_arg = Table(dataset.table(table_id), schema=SCHEMA) From f467438211f0af4e111b7dfa531340d5eba972d4 Mon Sep 17 00:00:00 2001 From: HemangChothani Date: Wed, 19 Aug 2020 12:29:17 +0530 Subject: [PATCH 2/3] fix: change dataset ids --- tests/system.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/system.py b/tests/system.py index 2718fef05..c72410c97 100644 --- a/tests/system.py +++ b/tests/system.py @@ -422,7 +422,7 @@ def test_create_table_w_time_partitioning_w_clustering_fields(self): self.assertEqual(table.clustering_fields, ["user_email", "store_code"]) def test_delete_dataset_with_string(self): - dataset_id = _make_dataset_id("delete_table_true") + dataset_id = _make_dataset_id("delete_table_true_with_string") project = Config.CLIENT.project dataset_ref = bigquery.DatasetReference(project, dataset_id) retry_403(Config.CLIENT.create_dataset)(Dataset(dataset_ref)) @@ -431,7 +431,7 @@ def test_delete_dataset_with_string(self): self.assertFalse(_dataset_exists(dataset_ref)) def test_delete_dataset_delete_contents_true(self): - dataset_id = _make_dataset_id("delete_table_true") + dataset_id = _make_dataset_id("delete_table_true_with_content") project = Config.CLIENT.project dataset_ref = bigquery.DatasetReference(project, dataset_id) dataset = retry_403(Config.CLIENT.create_dataset)( From 08f73dc47983836433285ca4a8ccb499d597f3e3 Mon Sep 17 00:00:00 2001 From: HemangChothani Date: Thu, 20 Aug 2020 11:51:42 +0530 Subject: [PATCH 3/3] fix: nit --- tests/system.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/system.py b/tests/system.py index c72410c97..0048c13e0 100644 --- a/tests/system.py +++ b/tests/system.py @@ -434,9 +434,7 @@ def test_delete_dataset_delete_contents_true(self): dataset_id = _make_dataset_id("delete_table_true_with_content") project = Config.CLIENT.project dataset_ref = bigquery.DatasetReference(project, dataset_id) - dataset = retry_403(Config.CLIENT.create_dataset)( - Dataset(dataset_ref), exists_ok=True - ) + dataset = retry_403(Config.CLIENT.create_dataset)(Dataset(dataset_ref)) table_id = "test_table" table_arg = Table(dataset.table(table_id), schema=SCHEMA)