Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proto-plus >= 1.25 needed for python 3.13 #979

Open
parthea opened this issue Oct 25, 2024 · 0 comments
Open

proto-plus >= 1.25 needed for python 3.13 #979

parthea opened this issue Oct 25, 2024 · 0 comments
Assignees
@daniel-sanche
Labels
api: firestore Issues related to the googleapis/python-firestore API.

Comments

@parthea
Copy link
Contributor

parthea commented Oct 25, 2024 •
edited
Loading

The setup.py file should be updated to require proto-plus >= 1.25 for python_version >=3.13 due to googleapis/proto-plus-python#490

See release notes here: https://github.com/googleapis/proto-plus-python/releases/tag/v1.25.0

Add "proto-plus >= 1.25.0, <2.0.0dev; python_version>='3.13'", after the following line

python-firestore/setup.py

Line 39 in 3fe7271

"proto-plus >= 1.22.2, <2.0.0dev; python_version>='3.11'",

As an example, see googleapis/python-api-core#740
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Oct 25, 2024
@dconeybe dconeybe assigned daniel-sanche and unassigned dconeybe Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-sanche daniel-sanche

Labels
api: firestore Issues related to the googleapis/python-firestore API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daniel-sanche @parthea @dconeybe