Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support running system tests that require indexes in CI #104

Closed
chrisrossi opened this issue Jun 5, 2019 · 1 comment
Closed

Support running system tests that require indexes in CI #104

chrisrossi opened this issue Jun 5, 2019 · 1 comment
Assignees
@cguardia
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@chrisrossi
Copy link
Contributor

Currently, any system tests that require indexes are marked to be skipped, due to the indexes not being created in the datastore instance being used for CI by Kokoro.

The indexes that would need to be created are in tests/system/indexes.yaml. The gcloud SDK is required to create indexes. The way to do this from the command line is:

$ gcloud datastore indexes create path/to/indexes.yaml

Unfortunately there is no way to do this programmatically via an API. Probably the nox script run by Kokoro could be updated to accomplish running this step.
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jun 6, 2019
@sduskis sduskis added type: cleanup An internal cleanup or hygiene concern. and removed 🚨 🚨 This issue needs some love. triage me I really want to be triaged. labels Jun 16, 2019
@cguardia
Copy link
Contributor

cguardia commented Aug 6, 2019

Fixed via #145.

@cguardia cguardia closed this as completed Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cguardia cguardia

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sduskis @chrisrossi @cguardia @yoshi-automation