Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Finish implementation of UserProperty. #301

Merged
merged 2 commits into from
Jan 28, 2020

Conversation

chrisrossi
Copy link
Contributor

This never actually worked.

Fixes #280

@chrisrossi chrisrossi requested a review from cguardia January 27, 2020 20:30
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 27, 2020
Copy link
Contributor

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

return user_entity

def _from_base_type(self, ds_entity):
"""Convert the user value from a datatsore entity.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: datastore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BadValueError when referencing ndb.UserProperty
3 participants