Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing _get_for_dict method #368

Merged
merged 2 commits into from
Mar 20, 2020
Merged

fix: add missing _get_for_dict method #368

merged 2 commits into from
Mar 20, 2020

Conversation

cguardia
Copy link
Contributor

refs #367.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 19, 2020
@cguardia cguardia requested a review from chrisrossi March 19, 2020 06:00
@cguardia
Copy link
Contributor Author

@chrisrossi hi, can you take a look at this one, please?

chrisrossi
chrisrossi approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@chrisrossi chrisrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cguardia cguardia added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 20, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 20, 2020
@cguardia cguardia merged commit 55b80ff into googleapis:master Mar 20, 2020
@cguardia cguardia mentioned this pull request Mar 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisrossi chrisrossi chrisrossi approved these changes

@andrewsg andrewsg Awaiting requested review from andrewsg

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cguardia @chrisrossi @googlebot @yoshi-kokoro